spangaer commented on code in PR #11:
URL: 
https://github.com/apache/pekko-persistence-dynamodb/pull/11#discussion_r1806121780


##########
src/main/scala/org/apache/pekko/persistence/dynamodb/journal/DynamoDBHelper.scala:
##########
@@ -38,13 +38,23 @@ private class RetryStateHolder(var retries: Int = 10, var 
backoff: FiniteDuratio
 object DynamoRetriableException {
   def unapply(ex: AmazonServiceException) = {
     ex match {
-      case _: ProvisionedThroughputExceededException =>
-        Some(ex)
+      // 50x network glitches
       case _: InternalServerErrorException =>
         Some(ex)
       case ase if ase.getStatusCode >= 502 && ase.getStatusCode <= 504 =>
         // retry on more common server errors
         Some(ex)
+
+      // 400 throughput issues
+      case _: ProvisionedThroughputExceededException =>
+        Some(ex)
+      case _: RequestLimitExceededException =>
+        // rate of on-demand requests exceeds the allowed account throughput
+        // and the table cannot be scaled further
+        Some(ex)
+      case ase if ase.getErrorCode == "ThrottlingException" =>
+        // // rate of AWS requests exceeds the allowed throughput

Review Comment:
   Note to self, clean-up double `//`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to