raboof commented on PR #391: URL: https://github.com/apache/pekko-grpc/pull/391#issuecomment-2439753981
> I would not favour merging this. It ties us to an unreleased version of pekko-http - and I think there is an argument that the real issue is in the AWS code. I agree we should not merge this as long as it depends on an unreleased version of Pekko HTTP. The PR is still in 'Draft' mode, so that tracks ;). I agree there's a case to be made that the 'real issue' of #392 is in the AWS implementation. That said, responding with a `Strict` response for errors like a 404 instead of streaming (which is the core of this PR) seems like a reasonable optimization regardless. It might still be possible to adapt this PR to avoid creating the situation where a `Trailers` object without any headers is created, so it can go back to using the regular released Pekko HTTP version. In any case it'll still take a couple of rounds of improvements to make this change nice and ready to merge, but I'm optimistic about the chances of getting there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
