NavidJalali commented on code in PR #391:
URL: https://github.com/apache/pekko-grpc/pull/391#discussion_r1818914938
##########
interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/GrpcExceptionDefaultHandleSpec.scala:
##########
@@ -58,7 +58,7 @@ class GrpcExceptionDefaultHandleSpec
case Seq(LastChunk("", List(`Status`("3")))) => // ok
}
case _: Strict =>
-
response.attribute(AttributeKeys.trailer).get.headers.contains("grpc-status" ->
"3")
+ response.headers.find(_.is("grpc-status")).map(_.value()) shouldBe
Some("3")
Review Comment:
Trying to understand what you mean, it is allowed under the spec but knowing
the implementation of the exception handler I know it will be a Strict. So
adding another match arm that is never hit won't do much. But we _**should**_
probably make sure that such a test exist that HTTP Responses produced should
100% have trailers in one of the two possible locaitons. I don't know if this
is the test to do it in tho, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
