Tomassino-ibm commented on code in PR #1919:
URL: https://github.com/apache/pekko/pull/1919#discussion_r2163439418


##########
persistence-typed-tests/src/test/scala/org/apache/pekko/persistence/typed/scaladsl/EventSourcedStashOverflowSpec.scala:
##########
@@ -55,10 +55,11 @@ object EventSourcedStashOverflowSpec {
     
SteppingInmemJournal.config("EventSourcedStashOverflow").withFallback(ConfigFactory.parseString(s"""
        pekko.persistence {
          typed {
-           stash-capacity = 1000 # enough to fail on stack size
+           stash-capacity = 20000 # enough to fail on stack size

Review Comment:
   I increased that number because in one attempt the test was no longer 
failing (I had reduced the amount of functions in the "recursion cycle" and so 
the stack overflow was no longer happening). That example runs in approximately 
1.5 seconds on my machine, but I can change it to 2000 if you want, that was 
definitely enough to trigger the failure in the original code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org

Reply via email to