Tomassino-ibm commented on PR #1919: URL: https://github.com/apache/pekko/pull/1919#issuecomment-2999537621
> I pushed [fdfa3f5](https://github.com/apache/pekko/commit/fdfa3f5f8d545d72ea480627609fafbdc27b6043) to your branch to fix the scalafmt and mima binary compat checks Hi @pjfanning, thanks a lot for the early review and the fixes :-). I don't know if this solution is acceptable, maybe it would have been possible to have a better and more elegant implementation by touching more parts of the code base. However, considering that I know very little of pekko internals, I tried to limit changes to the smallest possible portion of code. I haven't marked the pull request as ready yet because I have a few questions (in addition to the other comments above): - as you've probably noticed, the message of the second commit starts with "TMP AMEND" because I was planning to amend it instead of pushing more commits for other changes. I would still like to change it, but that would force you to reset your local branch. Is that ok for you? - regarding binary compatibility, I think we can reduce breaking changes if I remove the new `Command` type parameter of `RunningState`. That was added to avoid a type cast in `onCommand` (we would need to store the command as `Any` in `recOnCommandParams`), but it's not critical to the solution. Please let me know if I should do that. - reading again the initial [issue description](https://github.com/apache/pekko/issues/1327), I see that the same problem could be present in `DurableState` also. Should I also attempt to fix it? Is there a test to reproduce the issue there already? I've never used it, but I had a quick look at pekko code and it seems that porting the solution there is relatively easy. Of course also please let me know if there's anything else I should change in code or if I should try a different approach -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
