sbmpost commented on PR #1152:
URL: 
https://github.com/apache/pekko-connectors/pull/1152#issuecomment-3246089001

   @pjfanning 
   
   PR should be good now. Instead of introducing new QoS flags for the 
Subscribe message, I thought it was best to make it work with the existing QoS 
flags (see below). In this way existing code shouldn't need any modifications. 
I suppose someone will want to have a critical look before this is merged. I 
totally understand if this is going to take a while.
       
       val QoSAtMostOnceDelivery = ControlPacketFlags(0)
       val QoSAtLeastOnceDelivery = ControlPacketFlags(1 << 1)
       val QoSExactlyOnceDelivery = ControlPacketFlags(2 << 1)
       val QoSReserved = ControlPacketFlags(3 << 1)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org

Reply via email to