pjfanning commented on code in PR #1152: URL: https://github.com/apache/pekko-connectors/pull/1152#discussion_r2316642479
########## build.sbt: ########## @@ -505,6 +505,7 @@ def pekkoConnectorProject(projectId: String, }, mimaBinaryIssueFilters ++= Seq( ProblemFilters.exclude[Problem]("*.impl.*"), + ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.stream.connectors.mqtt.streaming.ControlPacketFlags.ReservedUnsubAck"), Review Comment: Can you have a look in the repo? We tend to use files in `src/mima-filters` to add the excludes - a new file with each PR that breaks bin compat. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org