pjfanning commented on code in PR #784:
URL: https://github.com/apache/pekko-http/pull/784#discussion_r2354916335
##########
http-core/src/main/scala/org/apache/pekko/http/impl/engine/server/HttpServerBluePrint.scala:
##########
@@ -404,9 +407,18 @@ private[http] object HttpServerBluePrint {
import pekko.http.impl.util.JavaMapping.Implicits._
/** JAVA API * */
- def update(timeout: Duration, handler: Function[model.HttpRequest,
model.HttpResponse]): Unit =
+ override def updateTimeout(timeout: java.time.Duration): Unit = {
+ val stimeout = if (timeout eq null) null else timeout.asScala
Review Comment:
I adjusted the code. The Scala DSL does support nulls but the Java DSL
doesn't need to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
