Copilot commented on code in PR #784: URL: https://github.com/apache/pekko-http/pull/784#discussion_r2356259019
########## http/src/main/scala/org/apache/pekko/http/javadsl/server/directives/BasicDirectives.scala: ########## @@ -43,13 +41,16 @@ import pekko.http.scaladsl.server.{ Directives => D } import pekko.http.scaladsl.util.FastFuture._ import java.lang.{ Iterable => JIterable } -import java.util.function.Supplier +import java.time.{ Duration => JDuration } import java.util.{ List => JList } import java.util.concurrent.CompletionStage +import java.util.function.{ Function => JFunction } import java.util.function.Predicate +import java.util.function.Supplier import scala.concurrent.{ ExecutionContext, ExecutionContextExecutor } import scala.concurrent.duration.FiniteDuration +import scala.jdk.DurationConverters._ Review Comment: The import `scala.jdk.DurationConverters._` should be `pekko.util.JavaDurationConverters._` to be consistent with other files in this PR that use the Pekko-specific duration converters. ```suggestion import pekko.util.JavaDurationConverters._ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org