pjfanning opened a new pull request, #809: URL: https://github.com/apache/pekko-http/pull/809
current code uses 3 different ways to lowercase a char * parboiled2 CharUtils method * an internal method on HttpHeaderParser * uses Java built-in Character.toLowerCase I did a jmh benchmark in my pekko-bench project https://github.com/pjfanning/pekko-bench/blob/main/src/main/scala/example/LowerCaseBench.scala And this showed that function in HttpHeaderParser was better than or matched the perf of the others on all Java versions. Parboiled2 was always slower. The Java built-in was as good for Java 21 and 25 but slowest approach in java 17 and below. This change switches all code to use the pekko-http internal method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
