pjfanning commented on PR #809: URL: https://github.com/apache/pekko-http/pull/809#issuecomment-3374120706
> I'm not sure why [d55eed0](https://github.com/apache/pekko-http/commit/d55eed032fbcc4b7e0eca15dd5e872d625c827b7) makes sense? It seems 'correct' but looks like it'd be slower if anything? The main part d55eed0 was to change to calling byteChar function. This should get inlined by Hotspot compiler. It is used in lots of places already and this usage seems strange not to use it. I can remove this change though and come back to it. Maybe the correct thing to do is actually make the inlining of byteChar explicit (by declaring `inline def byteChar` and `@inline def byteChar` which means slitting the code into Scala 2 and 3 versions of the package.scala). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
