He-Pin commented on code in PR #981: URL: https://github.com/apache/pekko-http/pull/981#discussion_r2901820989
########## http-core/src/main/scala/org/apache/pekko/http/impl/model/parser/UriParser.scala: ########## @@ -351,7 +351,8 @@ private[http] final class UriParser( // https://tools.ietf.org/html/rfc7540#section-8.1.2.3 def `http2-path-pseudo-header` = rule( `absolute-path` ~ optional('?' ~ rawQueryString) // origin-form - ) // TODO: asterisk-form + | '*' ~ run(setPath(Path.Empty)) ~ run { _rawQueryString = None } // asterisk-form (for OPTIONS requests) + ) Review Comment: This pseudo-header field MUST NOT be empty for "http" or "https" URIs; "http" or "https" URIs that do not contain a path component MUST include a value of '/'. The exception to this rule is an OPTIONS request for an "http" or "https" URI that does not include a path component; these MUST include a ":path" pseudo-header field with a value of '*' (see [[RFC7230], Section 5.3.4](https://datatracker.ietf.org/doc/html/rfc7230#section-5.3.4)). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
