jrudolph commented on code in PR #981: URL: https://github.com/apache/pekko-http/pull/981#discussion_r2904191207
########## http-core/src/main/scala/org/apache/pekko/http/impl/model/parser/UriParser.scala: ########## @@ -351,7 +351,8 @@ private[http] final class UriParser( // https://tools.ietf.org/html/rfc7540#section-8.1.2.3 def `http2-path-pseudo-header` = rule( `absolute-path` ~ optional('?' ~ rawQueryString) // origin-form - ) // TODO: asterisk-form + | '*' ~ run(setPath(Path.Empty)) ~ run { _rawQueryString = None } // asterisk-form (for OPTIONS requests) + ) Review Comment: Is there a test for this behavior? We need to demonstrate how users can deal with these requests. `Path.Empty` is likely not what user code wants to see for these requests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
