He-Pin commented on code in PR #3095:
URL: https://github.com/apache/pekko/pull/3095#discussion_r3444227386
##########
stream/src/main/scala/org/apache/pekko/stream/javadsl/Source.scala:
##########
@@ -692,6 +692,12 @@ object Source {
* @param bufferSize size of buffer in element count
* @param overflowStrategy Strategy that is used when incoming elements
cannot fit inside the buffer
*/
+ @deprecated(
+ "Prefer Source.queue(bufferSize) which materializes a BoundedSourceQueue
with synchronous feedback " +
+ "(dropping the newest element when the buffer is full). For backpressure,
use Source.actorRefWithBackpressure " +
+ "or MergeHub.source instead. See the Pekko Streams documentation for the
Source.queue migration guide.",
Review Comment:
Since these messages all end up in the mailbox, if the system is under heavy
load, the backpressure mechanism fails; you then see heap memory steadily
rising, followed by Full GCs, and eventually the system crashes. I think it’s
better to just remove it—how should I put it? The feature works fine under low
load, but it’s riddled with bugs under high load.
https://github.com/akkadotnet/akka.net/pull/8248 @Aaronontheweb FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
