He-Pin commented on code in PR #3095:
URL: https://github.com/apache/pekko/pull/3095#discussion_r3469770909
##########
stream/src/main/scala/org/apache/pekko/stream/javadsl/Source.scala:
##########
@@ -692,6 +692,12 @@ object Source {
* @param bufferSize size of buffer in element count
* @param overflowStrategy Strategy that is used when incoming elements
cannot fit inside the buffer
*/
+ @deprecated(
+ "Prefer Source.queue(bufferSize) which materializes a BoundedSourceQueue
with synchronous feedback " +
+ "(dropping the newest element when the buffer is full). For backpressure,
use Source.actorRefWithBackpressure " +
+ "or MergeHub.source instead. See the Pekko Streams documentation for the
Source.queue migration guide.",
Review Comment:
Wow, nice! Thanks for the comment. I maintain a Taobao livestreaming system;
initially, I used RxJava, but I frequently ran into OOM (Out of Memory) and FGC
(Full Garbage Collection) issues during broadcasts by top streamers. Later, I
switched to Akka Streams' `Source.queue`, but I still encountered FGC problems.
This had a huge impact on the streams of individual top broadcasters, and the
issue wasn't resolved until I finally switched to `BoundedSourceQueue`. The
system is running very smoothly now. thanks @jrudolph
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
