The GitHub Actions job "Scalafmt" on pekko.git/issue-3160-stale-reader-acks has failed. Run started by GitHub user He-Pin (triggered by He-Pin).
Head commit for run: 4a9b2ec3f769a59d99e7f80d63eb3409168294cb / 虎鸣 <[email protected]> fix: ignore stale classic remoting reader ACKs Motivation: Classic remoting ACKs forwarded by EndpointReader were not tied to the reader UID, so a delayed ACK from an old reader could affect the resend buffer after a new UID was confirmed. Modification: Tag decoded ACKs with the EndpointReader UID and have ReliableDeliverySupervisor only process ACKs from the currently confirmed UID. Add a supervisor-level regression test covering stale and current reader ACKs. Result: Stale reader ACKs are ignored while current-reader ACKs still acknowledge the active resend buffer. Tests: - sbt "remote / Test / testOnly org.apache.pekko.remote.ReliableDeliverySupervisorSpec" - sbt headerCreateAll - sbt +headerCheckAll - scalafmt --mode diff-ref=origin/main - scalafmt --list --mode diff-ref=origin/main - git diff --check - qodercli -p --output-format stream-json --attachment /tmp/pekko-3160-qoder-review.diff (No must-fix findings) - sbt sortImports (failed: scalafix/scala.meta NoSuchMethodError in stream-tests and multi-node-testkit) References: Fixes #3160 Report URL: https://github.com/apache/pekko/actions/runs/28114192342 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
