pjfanning commented on code in PR #1114:
URL: https://github.com/apache/pekko-http/pull/1114#discussion_r3502361018
##########
http-core/src/main/scala/org/apache/pekko/http/javadsl/model/ws/WebSocketUpgrade.scala:
##########
@@ -41,20 +41,50 @@ trait WebSocketUpgrade {
*/
def handleMessagesWith(handlerFlow: Graph[FlowShape[Message, Message], ? <:
Any]): HttpResponse
+ /**
+ * Returns a response that can be used to answer a WebSocket handshake
request. The connection will afterwards
+ * use the given handlerFlow to handle WebSocket messages from the client.
+ *
+ * The compressionEnabled flag allows declining negotiated WebSocket
compression for this accepted WebSocket.
+ */
+ def handleMessagesWith(
+ handlerFlow: Graph[FlowShape[Message, Message], ? <: Any],
compressionEnabled: Boolean): HttpResponse
+
/**
* Returns a response that can be used to answer a WebSocket handshake
request. The connection will afterwards
* use the given handlerFlow to handle WebSocket messages from the client.
The given subprotocol must be one
* of the ones offered by the client.
*/
def handleMessagesWith(handlerFlow: Graph[FlowShape[Message, Message], ? <:
Any], subprotocol: String): HttpResponse
+ /**
+ * Returns a response that can be used to answer a WebSocket handshake
request. The connection will afterwards
+ * use the given handlerFlow to handle WebSocket messages from the client.
The given subprotocol must be one
+ * of the ones offered by the client.
+ *
+ * The compressionEnabled flag allows declining negotiated WebSocket
compression for this accepted WebSocket.
Review Comment:
can you add `@since 2.0.0` on new public API methods
##########
http-core/src/main/scala/org/apache/pekko/http/javadsl/model/ws/WebSocketUpgrade.scala:
##########
@@ -41,20 +41,50 @@ trait WebSocketUpgrade {
*/
def handleMessagesWith(handlerFlow: Graph[FlowShape[Message, Message], ? <:
Any]): HttpResponse
+ /**
+ * Returns a response that can be used to answer a WebSocket handshake
request. The connection will afterwards
+ * use the given handlerFlow to handle WebSocket messages from the client.
+ *
+ * The compressionEnabled flag allows declining negotiated WebSocket
compression for this accepted WebSocket.
+ */
+ def handleMessagesWith(
+ handlerFlow: Graph[FlowShape[Message, Message], ? <: Any],
compressionEnabled: Boolean): HttpResponse
+
/**
* Returns a response that can be used to answer a WebSocket handshake
request. The connection will afterwards
* use the given handlerFlow to handle WebSocket messages from the client.
The given subprotocol must be one
* of the ones offered by the client.
*/
def handleMessagesWith(handlerFlow: Graph[FlowShape[Message, Message], ? <:
Any], subprotocol: String): HttpResponse
+ /**
+ * Returns a response that can be used to answer a WebSocket handshake
request. The connection will afterwards
+ * use the given handlerFlow to handle WebSocket messages from the client.
The given subprotocol must be one
+ * of the ones offered by the client.
+ *
+ * The compressionEnabled flag allows declining negotiated WebSocket
compression for this accepted WebSocket.
Review Comment:
can you add `@since 2.0.0` on new public API methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
