He-Pin commented on code in PR #3275: URL: https://github.com/apache/pekko/pull/3275#discussion_r3503327034
########## persistence-query/src/test/scala/org/apache/pekko/persistence/query/typed/EventEnvelopeSpec.scala: ########## @@ -0,0 +1,53 @@ +/* Review Comment: This file is not copied from Akka — it is a new directional test I wrote for this PR (as noted in the PR body under "Improvement over upstream: added an EventEnvelopeSpec directional test covering the filtered vs not loaded error behaviour, which upstream shipped without a test"). The Akka `EventEnvelopeSpec` tests metadata support (single/composite), while this one tests `filtered` vs `not loaded` error semantics. The standard Apache header is correct here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
