He-Pin commented on code in PR #3275:
URL: https://github.com/apache/pekko/pull/3275#discussion_r3503327794
##########
persistence/src/main/resources/reference.conf:
##########
@@ -233,14 +233,17 @@ pekko.actor {
serializers {
pekko-persistence-message =
"org.apache.pekko.persistence.serialization.MessageSerializer"
pekko-persistence-snapshot =
"org.apache.pekko.persistence.serialization.SnapshotSerializer"
+ pekko-persistence-filtered =
"org.apache.pekko.persistence.serialization.FilteredPayloadSerializer"
}
serialization-bindings {
"org.apache.pekko.persistence.serialization.Message" =
pekko-persistence-message
"org.apache.pekko.persistence.serialization.Snapshot" =
pekko-persistence-snapshot
+ "org.apache.pekko.persistence.FilteredPayload$" =
pekko-persistence-filtered
}
serialization-identifiers {
"org.apache.pekko.persistence.serialization.MessageSerializer" = 7
"org.apache.pekko.persistence.serialization.SnapshotSerializer" = 8
+ "org.apache.pekko.persistence.serialization.FilteredPayloadSerializer"
= 34
Review Comment:
Yes — serializer id 34 matches the upstream Akka id, following pekko's
established convention of preserving upstream serializer ids (e.g.
`ReplicatedEventSourcingSerializer = 40` also matches akka). Keeping this
aligned ensures wire compatibility for any plugin that already hard-codes id 34
for `FilteredPayload`. Noted in the PR body under "Serializer id: 34 matches
the upstream id".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
