pjfanning opened a new pull request, #907: URL: https://github.com/apache/pekko-management/pull/907
L12 — Eager client initialization: Changed ec2Client from val to lazy val (line 103 in Ec2TagBasedServiceDiscovery.scala). The ECS client was already lazy val. L13 — Unnecessary .toList materializations: - EC2 getInstances: Removed .toList from both .asScala.toList calls (lines 147–148), letting flatMap and map operate on the lazy Buffer from .asScala, with a single .toList at the end. - ECS describeTasks: Changed .grouped(100).toList to .grouped(100).toSeq (line 147), avoiding materializing the grouped iterator into a List of Seqs. L14 — Clients never closed: Added CoordinatedShutdown tasks in PhaseServiceUnbind that call shutdown() on both the EC2 and ECS clients (ec2Client.shutdown(), ecsClient.shutdown()). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
