timw commented on PR #1233: URL: https://github.com/apache/pekko-http/pull/1233#issuecomment-5431668779
@pjfanning - looks promising. I wonder if there'll be a performance benefit for clients - in my experience there's no benefit from applying `toStrict` in client code over simply processing a `Chunked` entity, but that could be because it's creating a separate stream, so I'm hopeful here. I don't fully understand the pekko-http HTTP/2 code, but I don't see where this collects the HTTP/2 trailers into the `trailer` response attribute, since the `ToStrict` focuses on the entity data stream only, and not the `Chunk` level where trailers arrive in a `LastChunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
