pjfanning commented on PR #1242: URL: https://github.com/apache/pekko-http/pull/1242#issuecomment-5479377031
Pushed 12c07b502 folding in the post-review state of the two in-flight PRs the model references: - **§14 Q3 / §9**: the symlink-rejection claim is now scoped to platforms where `File.getCanonicalPath` resolves links. On Windows it does not resolve NTFS symlinks/junctions (a caveat #1218 now documents at the function), so that link-escape residual is on record with `Path.toRealPath` as the principled follow-up, and the operator's link-free-tree choice carries containment there. Also noted: #1218 now rejects path segments no file-system path may contain (NUL, `<` on Windows) instead of letting them escape as server errors. - **§5**: the upload-directive note reflects #1217's rework — one temp directory per actor system removed by a `CoordinatedShutdown` task after the drain, replacing per-file `deleteOnExit`. (The earlier §12 note already records that this rework keeps the "registers no shutdown hook" claim true.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
