potiuk commented on PR #1242:
URL: https://github.com/apache/pekko-http/pull/1242#issuecomment-5572284908
This is better than what we drafted, and the three corrections are the
useful part — so, briefly, on each:
**§5 "writes no files".** Straightforwardly wrong, and worth naming as a
class rather than just a fix. The draft asserted a negative ("writes no files")
from a scan that hadn't enumerated the upload directives; `fileUploadAll` and
`storeUploadedFile(s)` were always there to be found. A model claiming a
capability is *absent* needs the same evidence as one claiming it's present,
and this one didn't have it.
**Q3 → #1218.** This is the one that matters. A string `startsWith` on
canonical paths passing `/var/www-private/` against a `/var/www` root is a real
escape, and the draft had it as an operator responsibility — i.e. the model
would have taught a future scan *not* to report it. Your reclassification to
`VALID` is right, and the Windows caveat (`getCanonicalPath` not resolving NTFS
junctions, `Path.toRealPath` as the principled fix) is the kind of
platform-specific qualification a generated draft reliably misses.
**The self-referential pin.** Fair, and embarrassing — pinning `444d939`
pinned this PR's own first commit rather than the `main` commit the claims were
verified against. `85d7243` is correct.
On merging: yes, merge it. You offered earlier to land it and finish with
the PMC, and I think that's right — the document is now yours in substance, and
the parts still moving (#1217's `CoordinatedShutdown` rework, #1218's
element-wise comparison) are yours to reconcile as they land. §12 already
records which claim each one invalidates, which is the part that usually gets
lost.
One thing worth recording rather than asking about: these three corrections
are the same failure mode several projects reported to us independently this
month — a claim inferred without walking the enforcement path to check it. The
§5 one is going back to the scan team as a concrete example of it, described by
shape rather than by project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
