minjibir commented on PR #489: URL: https://github.com/apache/pekko-persistence-r2dbc/pull/489#issuecomment-5658177896
Follow-up on the flush-on-completion part above. I measured all three variants locally (open-loop fixed cadence, plus idle and closed-loop runs). The two batched variants are identical when idle and when saturated; below saturation 05b866d issues more flushes and far more single-record flushes `(54 vs 6` at `~166 w/s`) with no throughput gain, matching the rationale in my earlier comment. Two follow-ups worth doing later: the idle fast path (flush immediately when the queue is empty and no flush is in flight), which removes the identical idle penalty from both variants, and a perf-spec comparison before any always-immediate opt-in setting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
