pjfanning commented on PR #489:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/489#issuecomment-5889716127
Thanks, this is pretty close now. A few small nits:
- `R2dbcBatchJournal.scala:203`: `case FlushDone(g) if g == generation`
leaves a stale `FlushDone` unmatched, so it goes to `unhandled()` and gets
logged as a dead letter. Prefer `case FlushDone(g) => if (g == generation) {
... }`.
- `R2dbcBatchJournal.scala:309`: the publish warning only logs
`exception.getMessage`, so the stack trace is lost. Please pass the exception
as the cause.
- `lastTimestampMicros` lives in the companion object, so it is shared
across the JVM rather than per journal actor. The scaladoc and `journal.md` say
"within this journal actor"; worth adjusting the wording.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
