Rayan-and-beyond commented on PR #1320: URL: https://github.com/apache/pekko-http/pull/1320#issuecomment-5888359989
Good point. I switched the new Java max-age accessor/mutator to `scala.jdk.DurationConverters` so the conversion is lossless and does not depend on `toMillis`. I also added a 1ns round-trip regression test. Validation after the change: - `Http2CommonSettingsSpec`: 3/3 - scalafmt checks: pass - `+http-core/compile`: pass on Scala 2.13.18 and 3.3.8 - `git diff --check`: pass I left the disabled value as `0s` for now because #1316 is still open and #1319 explicitly calls out `0s = disabled (default)`. Happy to align it to `infinite` once the server-side shape lands, or sooner if maintainers prefer that in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
