Rayan-and-beyond commented on PR #1320: URL: https://github.com/apache/pekko-http/pull/1320#issuecomment-5887921117
Thanks, these were good catches. Addressed in 30e52c4: - added `persistent-connection-max-age-jitter` with the same default/validation semantics as #1316 - moved max age + jitter onto the public Scala/Java `Http2ClientSettings` API and added MiMa excludes; `internalSettings` is back to `None` by default - fixed the closed+buffered inlet case so a request queued during retirement is still sent even if the request source completes - documented the break-before-make behavior, added latency/long-lived-stream caveats, and clarified `completion-timeout` - replaced the stage-level callback with direct tracking of the current `Connected` state - widened the retirement timing margins and added idle-retirement/lazy-reconnect coverage The buffered-request regression initially exposed one additional closed-inlet pull edge in the replacement connection; that is fixed too. Fresh validation is green: settings spec 3/3, full plaintext persistent-client spec 13/13 (including normal reconnect paths), TLS retirement 2/2, MiMa on Scala 2.13/3.3, scalafmt, docs, and `git diff --check`. CI is rerunning on the pushed commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
