pjfanning commented on code in PR #3658: URL: https://github.com/apache/pekko/pull/3658#discussion_r4358254760
########## actor/src/main/scala/org/apache/pekko/event/EventStream.scala: ########## @@ -9,6 +9,7 @@ /* * Copyright (C) 2009-2022 Lightbend Inc. <https://www.lightbend.com> + * Copyright (C) 2009-2023 Lightbend Inc. <https://www.lightbend.com> Review Comment: Please update the existing Lightbend notice in place rather than adding a second one: ```suggestion * Copyright (C) 2009-2023 Lightbend Inc. <https://www.lightbend.com> ``` ########## actor-typed-tests/src/test/scala/org/apache/pekko/actor/typed/eventstream/EventStreamSpec.scala: ########## @@ -9,6 +9,7 @@ /* * Copyright (C) 2019-2022 Lightbend Inc. <https://www.lightbend.com> + * Copyright (C) 2019-2023 Lightbend Inc. <https://www.lightbend.com> Review Comment: Please update the existing Lightbend notice in place rather than adding a second one: ```suggestion * Copyright (C) 2019-2023 Lightbend Inc. <https://www.lightbend.com> ``` ########## actor-typed/src/main/scala/org/apache/pekko/actor/typed/eventstream/EventStream.scala: ########## @@ -9,6 +9,7 @@ /* * Copyright (C) 2019-2022 Lightbend Inc. <https://www.lightbend.com> + * Copyright (C) 2019-2023 Lightbend Inc. <https://www.lightbend.com> Review Comment: Please update the existing Lightbend notice in place rather than adding a second one: ```suggestion * Copyright (C) 2019-2023 Lightbend Inc. <https://www.lightbend.com> ``` ########## docs/src/main/paradox/typed/event-stream.md: ########## @@ -39,6 +48,10 @@ It can be used as follows: It is possible to subscribe to common superclass: +For example, a subscription to `DeadLetter` receives ordinary dead letters. Messages marked with +`DeadLetterSuppression` are published as `SuppressedDeadLetter` instead. Subscribe to `AllDeadLetters` to receive both, +as shown below. Review Comment: nit: the new paragraph now sits between "It is possible to subscribe to common superclass:" and the snippet it introduces. Moving it above that sentence reads more naturally: ```suggestion A subscription to `DeadLetter` receives ordinary dead letters. Messages marked with `DeadLetterSuppression` are published as `SuppressedDeadLetter` instead. Subscribe to their common superclass `AllDeadLetters` to receive both. It is possible to subscribe to common superclass: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
