pjfanning commented on code in PR #3658: URL: https://github.com/apache/pekko/pull/3658#discussion_r4359974639
########## docs/src/main/paradox/typed/event-stream.md: ########## @@ -37,7 +46,11 @@ It can be used as follows: @@@ -It is possible to subscribe to common superclass: +A subscription to `DeadLetter` receives ordinary dead letters. Messages marked with +`DeadLetterSuppression` are published as `SuppressedDeadLetter` instead. Subscribe to their common superclass +`AllDeadLetters` to receive both. Review Comment: Nit: `AllDeadLetters` is also the superclass of `Dropped` and `UnhandledMessage`, so a subscriber gets those as well, not just the two types mentioned. Maybe say so to avoid surprises: ```suggestion `DeadLetterSuppression` are published as `SuppressedDeadLetter` instead. Subscribe to their common superclass `AllDeadLetters` to receive both, as well as `Dropped` and `UnhandledMessage`, which also extend it. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
