pjfanning commented on PR #3677: URL: https://github.com/apache/pekko/pull/3677#issuecomment-6381584503
Since this PR aims to make `AbstractShardAllocationStrategy` a complete Java API ahead of the 2.0 freeze: there is currently no documented or tested way for a Java strategy to also hook into `StartableAllocationStrategy.start()`. A Java implementer would have to implement the Scala trait on top of `AbstractShardAllocationStrategy`. That probably works, but it is undocumented and has no test. Could you either add a test (e.g. have `RecordingShardAllocationStrategy` implement `StartableAllocationStrategy` and assert `start()` is called) and mention it in the Javadoc, or expose a Java-friendly `start()` hook on the abstract class? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
