He-Pin commented on PR #3677: URL: https://github.com/apache/pekko/pull/3677#issuecomment-6385123768
Both halves are in now. `RecordingShardAllocationStrategy` implements `StartableAllocationStrategy`, the integration test asserts `start()` is called exactly once and before any `allocateShard` or `rebalance`, and the `AbstractShardAllocationStrategy` Javadoc points Java implementers at the trait and notes that `start()` must not block. The migration guide mentions it too. I did not add a separate `start()` hook on the abstract class. Implementing the existing Scala trait from Java works - it compiles to a single-method interface, so a Java class just declares `implements StartableAllocationStrategy` and `public void start()` - and a second hook would duplicate it while making the coordinator call `start()` on every Java strategy whether it wants the callback or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
