pjfanning commented on PR #517: URL: https://github.com/apache/pekko-persistence-r2dbc/pull/517#issuecomment-6400776710
Thanks @ptrdom for the detailed review and the branches. Addressed: 1. **Windows clock:** cherry-picked `h2-windows-clock`. 2. **Plugin tables:** cherry-picked `h2-dao-tables`, and added ea2bb0d so a failed table creation isn't cached and is retried on the next connection. - **Windows CI:** H2 job also runs on `windows-2025`. - **`OPTIMIZE_REUSE_RESULTS`:** reworded the PR note (still in `SetTypes`, effect in 2.4.240 unverified). - **Migration tool:** `migration.md` now says it only targets PostgreSQL and Yugabyte, because of `ON CONFLICT`. - **Docs:** getting started notes that tools reading the H2 tables before the plugins are used have to create them. The H2 suite passes locally on macOS (296 / 0). I haven't re-run PostgreSQL locally after these changes, so I'm relying on CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
