ptrdom commented on code in PR #517:
URL:
https://github.com/apache/pekko-persistence-r2dbc/pull/517#discussion_r4371761095
##########
.github/workflows/build-test.yml:
##########
@@ -265,6 +265,53 @@ jobs:
- name: test
run: sbt -Dpekko.persistence.r2dbc.dialect=mysql ++${{
matrix.SCALA_VERSION }} ${{ matrix.COMPILE_ONLY && 'Test/compile' || 'test' }}
+ test-h2:
+ name: Run tests with H2
+ runs-on: ${{ matrix.OS || 'ubuntu-latest' }}
+ strategy:
+ matrix:
+ SCALA_VERSION: [ 2.13, 3.3, 3.9 ]
+ JAVA_VERSION: [ 17, 21 ]
+ include:
+ # H2 needs no database container, and the coarse Windows clock
catches timestamp ordering issues
+ - OS: windows-2025
+ SCALA_VERSION: 2.13
+ JAVA_VERSION: 17
Review Comment:
This `include` entry is merged into the existing `(2.13, 17)` combination,
since it only adds the new `OS` key, so that job moves to Windows and Linux
loses it. With `OS` as a matrix axis, the include overwrites `OS` and becomes a
separate seventh job:
```suggestion
runs-on: ${{ matrix.OS }}
strategy:
matrix:
OS: [ ubuntu-latest ]
SCALA_VERSION: [ 2.13, 3.3, 3.9 ]
JAVA_VERSION: [ 17, 21 ]
include:
# H2 needs no database container, and the coarse Windows clock
catches timestamp ordering issues
- OS: windows-2025
SCALA_VERSION: 2.13
JAVA_VERSION: 17
```
The job names then include the OS, e.g. "Run tests with H2 (ubuntu-latest,
2.13, 17)".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
