pjfanning opened a new pull request, #661: URL: https://github.com/apache/pekko-persistence-jdbc/pull/661
### Motivation The javadsl `JdbcDurableStateStore` exposed a public constructor taking Slick and internal config types, and an unused public `queries` val leaking the internal `DurableStateQueries`. Users only obtain the store via `DurableStateStoreRegistry`, so 2.0.0 is a chance to hide these. ### Modification - Make the constructor `@InternalApi private[jdbc]` and drop the `JdbcProfile` / `DurableStateTableConfiguration` params that only fed `queries`. - Remove the unused `queries` val and the `@ApiMayChange` annotation. - Make `Identifier` final, matching javadsl `JdbcReadJournal`. - Fix the javadsl `currentLastSequenceNumberByPersistenceId` scaladoc to describe an empty `Optional` rather than `None`. - Add MiMa excludes for the removed members. A review of the javadsl found no input params with generic types that could be widened; nearly all methods override Pekko interfaces and already use Java types. ### Result The javadsl durable state store no longer exposes Scala/Slick internals in its public API. ### Tests - `sbt core/Test/compile`: success (includes `JavadslSnippets.java`) - `sbt core/mimaReportBinaryIssues`: success with new excludes ### References None - javadsl API tidy-up for 2.0.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
