Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/121#discussion_r109477449
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.api/src/main/java/org/apache/rya/indexing/pcj/fluo/api/CreatePcj.java
---
@@ -132,12 +132,12 @@ public CreatePcj(final int spInsertBatchSize) {
* @throws SailException Historic PCJ results could not be loaded
because of a problem with {@code rya}.
* @throws QueryEvaluationException Historic PCJ results could not be
loaded because of a problem with {@code rya}.
*/
- public void withRyaIntegration(final String pcjId, final
PrecomputedJoinStorage pcjStorage, final FluoClient fluo,
- final Connector accumulo, String ryaInstance )
- throws MalformedQueryException,
PcjException, SailException, QueryEvaluationException, RyaDAOException {
- requireNonNull(pcjId);
- requireNonNull(pcjStorage);
- requireNonNull(fluo);
+ public String withRyaIntegration(final String pcjId, final
PrecomputedJoinStorage pcjStorage, final FluoClient fluo,
--- End diff --
You need to update the method's documentation since you updated its
signature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
