Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/121#discussion_r109486620
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/export/rya/KafkaExportParameters.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.indexing.pcj.fluo.app.export.rya;
+
+import java.util.Map;
+import java.util.Properties;
+
+import org.apache.fluo.api.observer.Observer;
+import org.apache.rya.indexing.pcj.fluo.app.export.ParametersBase;
+
+/**
+ * Provides read/write functions to the parameters map that is passed into
an
+ * {@link Observer#init(io.fluo.api.observer.Observer.Context)} method
related
+ * to PCJ exporting to a kafka topic.
+ * Remember: if doesn't count unless it is added to params
+ */
+
+public class KafkaExportParameters extends ParametersBase {
+
+ public static final String CONF_EXPORT_TO_KAFKA =
"pcj.fluo.export.kafka.enabled";
+
+ public KafkaExportParameters(final Map<String, String> params) {
+ super(params);
+ }
+
+ /**
+ * @param isExportToKafka
+ * - {@code True} if the Fluo application should export
+ * to Kafka; otherwise {@code false}.
+ */
+ public void setExportToKafka(final boolean isExportToKafka) {
+ setBoolean(params, CONF_EXPORT_TO_KAFKA, isExportToKafka);
+ }
+
+ /**
+ * @return {@code True} if the Fluo application should export to
Kafka; otherwise
+ * {@code false}. Defaults to {@code false} if no value is
present.
+ */
+ public boolean isExportToKafka() {
+ return getBoolean(params, CONF_EXPORT_TO_KAFKA, false);
+ }
+
+ /**
+ * Add the properties to the params, NOT keeping them separate from
the other params.
+ * Guaranteed by Properties: Each key and its corresponding value in
the property list is a string.
+ *
+ * @param producerConfig
+ */
+ public void setProducerConfig(final Properties producerConfig) {
--- End diff --
This method name is kind of misleading because 'set' functions usually mean
you're just setting a single value within the object the set function is on.
Maybe rename this to "addProperties(Properties properties)"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
