Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/156#discussion_r112533438
--- Diff:
extras/rya.indexing.pcj/src/main/java/org/apache/rya/indexing/pcj/storage/accumulo/AccumuloPcjSerializer.java
---
@@ -112,24 +109,6 @@ public BindingSet convert(byte[] bindingSetBytes,
VariableOrder varOrder) throws
}
}
- /**
- * Checks to see if the names of all the {@link Binding}s in the
{@link BindingSet}
- * are a subset of the variables names in {@link VariableOrder}.
- *
- * @param bindingSet - The binding set whose Bindings will be
inspected. (not null)
- * @param varOrder - The names of the bindings that may appear in the
BindingSet. (not null)
- * @throws IllegalArgumentException Indicates the names of the
bindings are
- * not a subset of the variable order.
- */
- private static void checkBindingsSubsetOfVarOrder(BindingSet
bindingSet, VariableOrder varOrder) throws IllegalArgumentException {
- checkNotNull(bindingSet);
- checkNotNull(varOrder);
-
- Set<String> bindingNames = bindingSet.getBindingNames();
- List<String> varNames = varOrder.getVariableOrders();
- checkArgument(varNames.containsAll(bindingNames), "The BindingSet
contains a Binding whose name is not part of the VariableOrder.");
- }
-
--- End diff --
Why do away with this check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
