Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/156#discussion_r112534616
--- Diff:
extras/rya.indexing.pcj/src/main/java/org/apache/rya/indexing/pcj/storage/accumulo/BindingSetStringConverter.java
---
@@ -58,7 +56,13 @@
@Override
public String convert(final BindingSet bindingSet, final VariableOrder
varOrder) {
- checkBindingsSubsetOfVarOrder(bindingSet, varOrder);
+ requireNonNull(bindingSet);
+ requireNonNull(varOrder);
+
+ // If the binding set is empty, just return empty string.
+ if(bindingSet.getBindingNames().isEmpty()) {
+ return "";
+ }
--- End diff --
Seems like it would be better either throw an exception or to let the user
know that the bindingSetString was only being built using a subset of the
variables in varOrder in the event that the variables in varOrder aren't the
same as the variables in the BindingSet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
