[ 
https://issues.apache.org/jira/browse/RYA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100955#comment-16100955
 ] 

ASF GitHub Bot commented on RYA-324:
------------------------------------

Github user isper3at commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/182#discussion_r129453060
  
    --- Diff: 
extras/rya.geoindexing/geo.common/src/main/java/org/apache/rya/indexing/accumulo/geo/OptionalConfigUtils.java
 ---
    @@ -81,7 +82,17 @@ public static boolean getUseGeoTemporal(final 
Configuration conf) {
          * {@code null} if it doesn't exist.
          */
         public static GeoIndexerType getGeoIndexerType(final Configuration 
conf) {
    -        return conf.getEnum(GEO_INDEXER_TYPE, null);
    +           String confType[] = conf.getStrings(GEO_INDEXER_TYPE);
    --- End diff --
    
    there should be a get() that has a default value so you don't need to do a 
null check on confType


> geoWave and geoMesa depend on different versions of the GeoTools
> ----------------------------------------------------------------
>
>                 Key: RYA-324
>                 URL: https://issues.apache.org/jira/browse/RYA-324
>             Project: Rya
>          Issue Type: Bug
>          Components: sail
>    Affects Versions: 3.2.10
>            Reporter: David W. Lotts
>            Assignee: David W. Lotts
>              Labels: dependencies, geo, refactor
>             Fix For: 3.2.10
>
>
> Refactored geo libraries into separate projects/modules/jars.
> Geo libraries are optional and turned off by default because the GeoTools is 
> has an incompatible license.
> Further, geoWave and geoMesa depend on different versions of the GeoTools, so 
> they must be in separate projects.
> The new modules (projects) are
> geo.common
> geo.mongo
> geo.geomesa
> geo.geowave
> These are modules of the project rya.geoindexing



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to