[
https://issues.apache.org/jira/browse/RYA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104295#comment-16104295
]
ASF GitHub Bot commented on RYA-324:
------------------------------------
Github user pujav65 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/182#discussion_r129997683
--- Diff:
extras/rya.geoindexing/geo.common/src/main/java/org/apache/rya/indexing/GeoEnabledFilterFunctionOptimizer.java
---
@@ -98,18 +96,23 @@ public void setConf(final Configuration conf) {
init = false;
init();
}
-
+ /**
+ * Load instances of the selected indexers. This is tricky because
some (geomesa vs geowave) have incompatible dependencies (geotools versions).
+ */
private synchronized void init() {
if (!init) {
- if (ConfigUtils.getUseMongo(conf)) {
- geoIndexer = new MongoGeoIndexer();
- geoIndexer.setConf(conf);
- freeTextIndexer = new MongoFreeTextIndexer();
- freeTextIndexer.setConf(conf);
- temporalIndexer = new MongoTemporalIndexer();
- temporalIndexer.setConf(conf);
+ if (ConfigUtils.getUseMongo(conf)) {
+ // create a new MongoGeoIndexer() without
having it at compile time.
+ geoIndexer =
instantiate(GeoIndexerType.MONGO_DB.getGeoIndexerClassString(),
GeoIndexer.class);
+ geoIndexer.setConf(conf);
+ freeTextIndexer = new MongoFreeTextIndexer();
+ freeTextIndexer.setConf(conf);
+ temporalIndexer = new MongoTemporalIndexer();
+ temporalIndexer.setConf(conf);
} else {
- geoIndexer = new GeoMesaGeoIndexer();
+ //geoIndexer = new GeoMesaGeoIndexer();
--- End diff --
can you remove the commented out code?
> geoWave and geoMesa depend on different versions of the GeoTools
> ----------------------------------------------------------------
>
> Key: RYA-324
> URL: https://issues.apache.org/jira/browse/RYA-324
> Project: Rya
> Issue Type: Bug
> Components: sail
> Affects Versions: 3.2.10
> Reporter: David W. Lotts
> Assignee: David W. Lotts
> Labels: dependencies, geo, refactor
> Fix For: 3.2.10
>
>
> Refactored geo libraries into separate projects/modules/jars.
> Geo libraries are optional and turned off by default because the GeoTools is
> has an incompatible license.
> Further, geoWave and geoMesa depend on different versions of the GeoTools, so
> they must be in separate projects.
> The new modules (projects) are
> geo.common
> geo.mongo
> geo.geomesa
> geo.geowave
> These are modules of the project rya.geoindexing
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
