[
https://issues.apache.org/jira/browse/RYA-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104968#comment-16104968
]
ASF GitHub Bot commented on RYA-318:
------------------------------------
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/188#discussion_r130091543
--- Diff:
common/rya.api/src/main/java/org/apache/rya/api/client/LoadStatementsFile.java
---
@@ -31,14 +31,16 @@
@DefaultAnnotation(NonNull.class)
public interface LoadStatementsFile {
- /**
- * Loads a local file of RDF statements into an instance of Rya.
- *
- * @param ryaInstanceName - The name of the Rya instance the
statements will be loaded into. (not null)
- * @param statementsFile - A file that holds RDF statements that will
be loaded. (not null)
- * @param format - The format of the statements file. (not null)
- * @throws InstanceDoesNotExistException No instance of Rya exists for
the provided name.
- * @throws RyaClientException Something caused the command to fail.
- */
- public void loadStatements(String ryaInstanceName, Path
statementsFile, RDFFormat format) throws InstanceDoesNotExistException,
RyaClientException;
+ /**
+ * Loads a local file of RDF statements into an instance of Rya.
+ *
+ * @param ryaInstanceName - The name of the Rya instance the statements
will be loaded into. (not null)
+ * @param statementsFile - A file that holds RDF statements that will
be loaded. (not null)
+ * @param format - The format of the statements file. (not null)
+ * @param flushEachUpdate - If true, each statement will be flushed
individually. If false, statements will be
+ * grouped in an unspecified manner. A value of false will
typically yield higher ingest rates.
+ * @throws InstanceDoesNotExistException No instance of Rya exists for
the provided name.
+ * @throws RyaClientException Something caused the command to fail.
+ */
+ public void loadStatements(String ryaInstanceName, Path
statementsFile, RDFFormat format, boolean flushEachUpdate) throws
InstanceDoesNotExistException, RyaClientException;
--- End diff --
Good catch. I think this (and other future config settings) will need to
be handled by the RyaConnectionCommands.connectToAccumulo() function.
Currently it is nice to be able to change it while being connected, but it
keeps the API cleaner if we move it. I'll make the adjustment.
> Add Loading Data and Executing SPARQL Queries to the Rya Shell
> --------------------------------------------------------------
>
> Key: RYA-318
> URL: https://issues.apache.org/jira/browse/RYA-318
> Project: Rya
> Issue Type: Sub-task
> Components: clients
> Reporter: Jeff Dasch
> Assignee: Jeff Dasch
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
