[ 
https://issues.apache.org/jira/browse/RYA-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104979#comment-16104979
 ] 

ASF GitHub Bot commented on RYA-318:
------------------------------------

Github user jdasch commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/188#discussion_r130092402
  
    --- Diff: 
extras/rya.console/src/main/java/org/apache/rya/shell/RyaAdminCommands.java ---
    @@ -200,8 +201,65 @@ public String install() {
             }
         }
     
    -    @CliCommand(value = GET_INSTANCE_DETAILS_CMD, help = "Print 
information about how the Rya instance is configured.")
    -    public String getInstanceDetails() {
    +    @CliCommand(value = INSTALL_PARAMETERS_CMD, help = "Create a new 
instance of Rya with command line parameters.")
    +    public String installWithParameters(
    +            @CliOption(key = {"instanceName"}, mandatory = true, help = 
"The name of the Rya instance to create.")
    +            final String instanceName,
    +
    +            @CliOption(key = {"enableTableHashPrefix"}, mandatory = false, 
help = "Use Shard Balancing (improves streamed input write speeds).", 
unspecifiedDefaultValue = "false", specifiedDefaultValue = "true")
    +            final boolean enableTableHashPrefix,
    +
    +            @CliOption(key = {"enableEntityCentricIndex"}, mandatory = 
false, help = "Use Entity Centric Indexing.", unspecifiedDefaultValue = 
"false", specifiedDefaultValue = "true")
    +            final boolean enableEntityCentricIndex,
    +
    +            @CliOption(key = {"enableFreeTextIndex"}, mandatory = false, 
help = "Use Free Text Indexing.", unspecifiedDefaultValue = "false", 
specifiedDefaultValue = "true")
    +            final boolean enableFreeTextIndex,
    +
    +            @CliOption(key = {"enableGeospatialIndex"}, mandatory = false, 
help = "Use Geospatial Indexing.", unspecifiedDefaultValue = "false", 
specifiedDefaultValue = "true")
    +            final boolean enableGeospatialIndex,
    +
    +            @CliOption(key = {"enableTemporalIndex"}, mandatory = false, 
help = "Use Temporal Indexing.", unspecifiedDefaultValue = "false", 
specifiedDefaultValue = "true")
    +            final boolean enableTemporalIndex,
    +
    +            @CliOption(key = {"enablePcjIndex"}, mandatory = false, help = 
"Use Precomputed Join (PCJ) Indexing.", unspecifiedDefaultValue = "false", 
specifiedDefaultValue = "true")
    +            final boolean enablePcjIndex,
    +
    +            @CliOption(key = {"fluoPcjAppName"}, mandatory = false, help = 
"Fluo Application Name for PCJ Index Updater (fluo app must be initialized and 
enablePcjIndex=true).")
    --- End diff --
    
    I agree that it is Accumulo specific, but what I'm doing here is no 
different than the interactive code that was already in the InstallPrompt.  
When Mongo support is added, we can label these features as Accumulo only in 
the command help, maybe even prefix the names to make it more obvious -- and 
they'll fail immediately if the user tries to use them.  The interactive 
command can just hide invalid options from the user.



> Add Loading Data and Executing SPARQL Queries to the Rya Shell
> --------------------------------------------------------------
>
>                 Key: RYA-318
>                 URL: https://issues.apache.org/jira/browse/RYA-318
>             Project: Rya
>          Issue Type: Sub-task
>          Components: clients
>            Reporter: Jeff Dasch
>            Assignee: Jeff Dasch
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to