Github user pujav65 commented on a diff in the pull request:
    --- Diff: 
    @@ -53,8 +54,11 @@
         public static final String OBJECT_TYPE_VALUE = 
         public static final String CONTEXT = "context";
         public static final String PREDICATE = "predicate";
    -    public static final String OBJECT = "object";
    +    public static final String PREDICATE_HASH = "predicate_hash";
    +    public static final String OBJECT = "object_original";
    --- End diff --
    hey i don't think we need to hash predicates and subjects - just objects.  
objects are possibly literals which means they can have unspecified length (and 
in practice are likely to be very long -- sometimes people literally put books 
into comments which are object values).  theoretically predicates and subjects 
are URIs which means that to be valid they are limited in length.  no harm in 
doing it, it just adds a layer of indirection at query time.  

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to