Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/213#discussion_r134851821
--- Diff:
extras/rya.pcj.fluo/pcj.fluo.app/src/main/java/org/apache/rya/indexing/pcj/fluo/app/export/kafka/KafkaExportParameterBase.java
---
@@ -31,29 +32,25 @@
* Remember: if doesn't count unless it is added to params
*/
-public class KafkaExportParameters extends ParametersBase {
+public class KafkaExportParameterBase extends ParametersBase {
- public static final String CONF_EXPORT_TO_KAFKA =
"pcj.fluo.export.kafka.enabled";
-
- public KafkaExportParameters(final Map<String, String> params) {
+ public KafkaExportParameterBase(final Map<String, String> params) {
super(params);
}
/**
- * @param isExportToKafka
- * - {@code True} if the Fluo application should export
- * to Kafka; otherwise {@code false}.
+ * Sets the bootstrap servers for reading from and writing to Kafka
+ * @param bootstrapServers - connect string for Kafka brokers
*/
- public void setExportToKafka(final boolean isExportToKafka) {
- setBoolean(params, CONF_EXPORT_TO_KAFKA, isExportToKafka);
+ public void setKafkaBootStrapServers(String bootstrapServers) {
+ params.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG,
bootstrapServers);
}
-
+
/**
- * @return {@code True} if the Fluo application should export to
Kafka; otherwise
- * {@code false}. Defaults to {@code false} if no value is
present.
+ * @return Connect string for Kafka servers
*/
- public boolean isExportToKafka() {
- return getBoolean(params, CONF_EXPORT_TO_KAFKA, false);
+ public String getKafkaBootStrapServers() {
+ return params.get(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG);
--- End diff --
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
