Github user ejwhite922 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/213#discussion_r135066531
  
    --- Diff: 
common/rya.api/src/main/java/org/apache/rya/api/client/CreatePCJ.java ---
    @@ -27,8 +29,28 @@
     @DefaultAnnotation(NonNull.class)
     public interface CreatePCJ {
     
    +    public static enum QueryType{Construct, Projection, Periodic};
    +    public static enum ExportStrategy{Rya, Kafka, NoOpExport};
    --- End diff --
    
    Add javadocs for the enums and their types.  Also change the names for the 
types to all caps with words separated by _.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to