[ 
https://issues.apache.org/jira/browse/RYA-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147454#comment-16147454
 ] 

ASF GitHub Bot commented on RYA-266:
------------------------------------

Github user meiercaleb commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/149#discussion_r136105878
  
    --- Diff: 
mapreduce/src/main/java/org/apache/rya/accumulo/mr/RyaOutputFormat.java ---
    @@ -216,12 +215,22 @@ private static FreeTextIndexer 
getFreeTextIndexer(Configuration conf) {
             return freeText;
         }
     
    -    private static TemporalIndexer getTemporalIndexer(Configuration conf) {
    +    private static TemporalIndexer getTemporalIndexer(Configuration conf) 
throws IOException {
             if (!conf.getBoolean(ENABLE_TEMPORAL, true)) {
                 return null;
             }
             AccumuloTemporalIndexer temporal = new AccumuloTemporalIndexer();
             temporal.setConf(conf);
    +        Connector connector;
    +        try {
    +            connector = ConfigUtils.getConnector(conf);
    +        } catch (AccumuloException | AccumuloSecurityException e) {
    +            throw new IOException("Error when attempting to create a 
connection for writing the temporal index.", e);
    +        }
    +        MultiTableBatchWriter mtbw = 
connector.createMultiTableBatchWriter(new BatchWriterConfig());
    --- End diff --
    
    Why are you creating the multitable batch writer here?  Can't you use the 
same  batchwriter that the other indexes are using?  Have your 
getTemporalIndexer(...) method take in a MultiTableBatchWriter as well.


> Temporal index fails to write when using non-mock accumulo
> ----------------------------------------------------------
>
>                 Key: RYA-266
>                 URL: https://issues.apache.org/jira/browse/RYA-266
>             Project: Rya
>          Issue Type: Sub-task
>          Components: dao, sail
>         Environment: indexing
>            Reporter: David W. Lotts
>            Assignee: David W. Lotts
>            Priority: Blocker
>              Labels: flush, index, temporal
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Temporal indexing writes nothing to it's table name: [prefix]temporal.
> It does seem to work for a mock instance.  It might also work for a large 
> ingest since it would force a flush.
> See the parent RYA-72 for an explanation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to