[ 
https://issues.apache.org/jira/browse/RYA-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310175#comment-16310175
 ] 

ASF GitHub Bot commented on RYA-414:
------------------------------------

Github user kchilton2 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/256#discussion_r159509885
  
    --- Diff: 
dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/EmbeddedMongoFactory.java 
---
    @@ -79,19 +79,27 @@ private int findRandomOpenPortOnAllLocalInterfaces() 
throws IOException {
     
         /**
          * Creates a new Mongo connection.
    -     * 
    +     *
          * @throws MongoException
          * @throws UnknownHostException
          */
         public MongoClient newMongoClient() throws UnknownHostException, 
MongoException {
             return new MongoClient(new 
ServerAddress(mongodProcess.getConfig().net().getServerAddress(), 
mongodProcess.getConfig().net().getPort()));
         }
     
    +    /**
    +     * Gives access to the process configuration.
    --- End diff --
    
    Done.


> Fix inconsistent method of using MongoClient within a Sail object
> -----------------------------------------------------------------
>
>                 Key: RYA-414
>                 URL: https://issues.apache.org/jira/browse/RYA-414
>             Project: Rya
>          Issue Type: Bug
>            Reporter: Andrew Smith
>            Assignee: Kevin Chilton
>            Priority: Blocker
>
> We've decided to introduce a stateful configuration object that is used to 
> hold onto objects that needs to be shared across components within a Sail 
> object in favor of having a static holder. The static holder limited our 
> ability to use more than a single Sail object within a single JVM because all 
> of those Sail objects would all have to access the same Mongo DB repository.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to