[ 
https://issues.apache.org/jira/browse/RYA-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310188#comment-16310188
 ] 

ASF GitHub Bot commented on RYA-414:
------------------------------------

Github user kchilton2 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/256#discussion_r159512045
  
    --- Diff: 
dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/MongoDBRdfConfiguration.java
 ---
    @@ -92,184 +93,162 @@ public MongoDBRdfConfiguration clone() {
             return new MongoDBRdfConfiguration(this);
         }
     
    -    public Authorizations getAuthorizations() {
    -        final String[] auths = getAuths();
    -        if (auths == null || auths.length == 0) {
    -            return MongoDbRdfConstants.ALL_AUTHORIZATIONS;
    -        }
    -        return new Authorizations(auths);
    -    }
    -
         /**
    -     * @return {@code true} if each statement added to the batch writer 
should
    -     * be flushed and written right away to the datastore. {@code false} 
if the
    -     * statements should be queued and written to the datastore when the 
queue
    -     * is full or after enough time has passed without a write.<p>
    -     * Defaults to {@code true} if nothing is specified.
    +     * Set whether the Rya client should spin up an embedded MongoDB 
instance and connect to that
    +     * or if it should connect to a MongoDB Server that is running 
somewhere.
    +     *
    +     * @param useMock - {@true} to use an embedded Mongo DB instance; 
{@code false} to connect to a real server.
    --- End diff --
    
    Done.


> Fix inconsistent method of using MongoClient within a Sail object
> -----------------------------------------------------------------
>
>                 Key: RYA-414
>                 URL: https://issues.apache.org/jira/browse/RYA-414
>             Project: Rya
>          Issue Type: Bug
>            Reporter: Andrew Smith
>            Assignee: Kevin Chilton
>            Priority: Blocker
>
> We've decided to introduce a stateful configuration object that is used to 
> hold onto objects that needs to be shared across components within a Sail 
> object in favor of having a static holder. The static holder limited our 
> ability to use more than a single Sail object within a single JVM because all 
> of those Sail objects would all have to access the same Mongo DB repository.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to