[ 
https://issues.apache.org/jira/browse/RYA-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329282#comment-16329282
 ] 

ASF GitHub Bot commented on RYA-442:
------------------------------------

Github user ejwhite922 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/265#discussion_r162155859
  
    --- Diff: 
extras/rya.streams/api/src/main/java/org/apache/rya/streams/api/queries/QueryChange.java
 ---
    @@ -37,9 +37,11 @@
     @DefaultAnnotation(NonNull.class)
     public final class QueryChange implements Serializable {
         private static final long serialVersionUID = 1L;
    +
         private final UUID queryId;
         private final ChangeType changeType;
         private final Optional<String> sparql;
    +    private final Optional<Boolean> isActive;
    --- End diff --
    
    Why can't this just be a primitive boolean so a null value isn't possible?


> KafkaStreams: Implement the StartQuery and StopQuery interactors.
> -----------------------------------------------------------------
>
>                 Key: RYA-442
>                 URL: https://issues.apache.org/jira/browse/RYA-442
>             Project: Rya
>          Issue Type: Task
>            Reporter: Kevin Chilton
>            Assignee: Kevin Chilton
>            Priority: Major
>
> We need implementations of the StartQuery and StopQuery interfaces that 
> interact with the QueryRepository to update the isActive state of a 
> StreamsQuery in Rya Streams.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to