[
https://issues.apache.org/jira/browse/RYA-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329439#comment-16329439
]
ASF GitHub Bot commented on RYA-442:
------------------------------------
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/265#discussion_r162173679
--- Diff:
extras/rya.streams/api/src/main/java/org/apache/rya/streams/api/entity/StreamsQuery.java
---
@@ -60,17 +63,25 @@ public String getSparql() {
return sparql;
}
+ /**
+ * @return {@code true} if Rya Streams should process this query;
otherwise {@code false}.
+ */
+ public boolean isActive() {
+ return isActive;
+ }
+
@Override
public int hashCode() {
- return Objects.hash(queryId, sparql);
+ return Objects.hash(queryId, sparql, isActive);
}
@Override
public boolean equals(final Object o) {
if(o instanceof StreamsQuery) {
final StreamsQuery other = (StreamsQuery) o;
return Objects.equals(queryId, other.queryId) &&
--- End diff --
Why? This requires less object construction, so I'm not going to do that.
> KafkaStreams: Implement the StartQuery and StopQuery interactors.
> -----------------------------------------------------------------
>
> Key: RYA-442
> URL: https://issues.apache.org/jira/browse/RYA-442
> Project: Rya
> Issue Type: Task
> Reporter: Kevin Chilton
> Assignee: Kevin Chilton
> Priority: Major
>
> We need implementations of the StartQuery and StopQuery interfaces that
> interact with the QueryRepository to update the isActive state of a
> StreamsQuery in Rya Streams.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
